D14511: [TerminalDisplay] Handle forward/backward buttons to switch tabs

[Tomaz Canabrava]

tcanabrava requested changes to this revision.
tcanabrava added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> MainWindow.cpp:894
> +    if (obj != _pluggedController->view()) {
> +        return QObject::eventFilter(obj, event);
> +    }

return KXmlGuiWindow::eventFilter ?

> MainWindow.cpp:902-907
> +            if (auto nextView = actionCollection()->action(QStringLiteral("next-view"))) {
> +                if (nextView->isEnabled()) {
> +                    nextView->trigger();
> +                    return true;
> +                }
> +            }

extract those to a function so you don't repeat yourself?
case Qt::ForwardButton: triggerAction("next-view");
case Qt::BackButton: triggerAction("previus-view");

?

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D14511

To: anthonyfieroni, #konsole, hindenburg, tcanabrava
Cc: tcanabrava, ngraham, konsole-devel, herrold, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180917/ff505169/attachment.html>