D15295: [konsole]: proper fix for a crash-on-exit

[René J.V. Bertin]

rjvbb added a comment.


  > it should be connected destroyed to containerEmpty too.
  
  I'm not sure I see why TabbedViewContainer::destroyed should be connected to SplitterView::containerEmpty; I think that would lead to calling containerEmpty too often.
  
  What I can imagine is this: in containerDestroyed, check if the container being deleted is empty. If not, call containerEmpty directly *after* removing the container from _containers.
  
  However, I notice these warnings when I close a Konsole window with multiple tabs open (here, 3):
  
    shell did not close, sending SIGHUP
    shell did not close, sending SIGHUP
    shell did not close, sending SIGHUP
  
  That could mean that the TabbedViewContainer dtor empties the container, and that could well mean that the empty signal is sent and containerEmpty is thus called?

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D15295

To: rjvbb, #konsole, gateau, hindenburg
Cc: anthonyfieroni, tcanabrava, konsole-devel, #kde_applications, herrold, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180905/76f369be/attachment.html>