D16134: Secure history file

[Dórian Langbeck]

langbeck added a comment.


  @hindenburg, I'm using Debian Buster and `apt-cache` shows that `kde-runtime` depends on `libplasma3` that depends on `libqca2`.
  
  Regarding @tcanabrava's request, I don't have experience with UI and I wouldn't know how to easily change the UI to show such option.
  What I can do is add a build switch using a `cmake` option. But I don't know how to easily/elegantly add such code switch.
  
  If you want manually enable/disable the feature in the code you just need to switch from
  
    SecureHistoryFile _index; // lines Row(qint64)
    SecureHistoryFile _cells; // text  Row(Character)
    HistoryFile _lineflags; // flags Row(unsigned char)
  
  to
  
    HistoryFile _index; // lines Row(qint64)
    HistoryFile _cells; // text  Row(Character)
    HistoryFile _lineflags; // flags Row(unsigned char)
  
  and that's it.
  
  All the rest of the code will not be exercited if these two instances of `SecureHistoryFile` are removed (the performance effect is the same that without this feature enabled).

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D16134

To: langbeck, tcanabrava, hindenburg, #konsole
Cc: frederico, konsole-devel, herrold, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20181013/99aa2ee6/attachment.html>