D16159: Fix double click can only select text within visible region

[Pavel Khlebovich]

pavelkh created this revision.
pavelkh added reviewers: Konsole, hindenburg, cfeck.
Herald added a project: Konsole.
Herald added a subscriber: konsole-devel.
pavelkh requested review of this revision.

REVISION SUMMARY
  This is a reimplemented 914067d14a6a27b59bba1c53cc18cb67eb9811fc <https://phabricator.kde.org/R319:914067d14a6a27b59bba1c53cc18cb67eb9811fc> (hinted by @cfeck), plus a refactoring of TerminalDisplay::findWordStart()
  
  findWordStart() had bounds check issues and an off-by-one for the case when the acquired region was more than two screens down.
  
  TerminalDisplay::findWordEnd() is very similarly implemented, but I haven't found a case where it fails, so I haven't touched it.
  
  Since 914067d14a6a27b59bba1c53cc18cb67eb9811fc <https://phabricator.kde.org/R319:914067d14a6a27b59bba1c53cc18cb67eb9811fc> caused a revert, I've tested the changes thoroughly (the cases are in the Test Plan below).
  
  Fixes BUG 399109

TEST PLAN
  Corner cases tested (everything was run under valgrind, since I had no crashes without it pre - f98c752bce9fa11f1e81cf6ef8c02b3c3861c341 <https://phabricator.kde.org/R319:f98c752bce9fa11f1e81cf6ef8c02b3c3861c341>):
  
  - At the end of the word, current Konsole doesn't select "@" at the end of the word when double-clicking, but selects it when the mouse is moved. With the introduced changes the behavior is to consistently ignore the last "@" character.
  - When 10K lines buffer is underfilled, dragged doubleclick+scrolled up by dragging the mouse above the terminal (this generates valgrind warnings on 5a31b4af6ddaba36866d092cb169faec3ca2cef1 <https://phabricator.kde.org/R319:5a31b4af6ddaba36866d092cb169faec3ca2cef1> that might have caused Konsole to crash)
  - Same with overfilled 10K lines buffer.
  - With decreased window size and some chars hidden, dblclick and drag up and down to the end of the buffer. The ends of the string are trimmed (like in current console), the rest of the string is properly selected.
  - With increased window size and padded chars, prod the buffer limits. Long lines are broken into separate lines -- no difference vs current Konsole.

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D16159

AFFECTED FILES
  src/TerminalDisplay.cpp

To: pavelkh, #konsole, hindenburg, cfeck
Cc: cfeck, konsole-devel, herrold, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20181012/605b25f1/attachment.html>