D15923: Fix system language dependent unit test

[Peter Braun]

pbraun created this revision.
pbraun added a reviewer: Konsole.
pbraun added a project: Konsole.
Herald added a subscriber: konsole-devel.
pbraun requested review of this revision.

REVISION SUMMARY
  When running the konsole unit tests on a system where the language setting is not english the test`ProfileTest::testFallbackProfile` fails because it compares the translated value of the `Name` property with the string literal `"Default"`. To fix the test we can use `UntranslatedName` instead.

TEST PLAN
  1. Run the konsole unit tests on a system where the language is not english
  
  Output of `ctest --verbose` before the fix:
  
    8: FAIL!  : Konsole::ProfileTest::testFallbackProfile() Compared values are not the same
    8:    Actual   (fallback->property<QString>(Profile::Name)): "Standard"
    8:    Expected (QStringLiteral("Default"))                 : "Default"
    8:    Loc: [/var/run/media/peter/MEDIA/Projects/kde/konsole/src/autotests/ProfileTest.cpp(237)]
  
  After the fix all tests should pass.

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D15923

AFFECTED FILES
  src/autotests/ProfileTest.cpp

To: pbraun, #konsole
Cc: konsole-devel, herrold, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20181003/95de1a82/attachment-0001.html>