D17221: Don't hide setFont, it's not virtual
Tomaz Canabrava
noreply at phabricator.kde.org
Wed Nov 28 18:32:19 GMT 2018
tcanabrava created this revision.
Herald added a project: Konsole.
Herald added a subscriber: konsole-devel.
tcanabrava requested review of this revision.
REVISION SUMMARY
setFont is not a virtual method, so overriding it makes no sense.
if you have a pointer to the widget and call setFont things will
still (not) work, and if you have a pointer to the TerminalDisplay
and call setFont, nothing will happen, so just remove it.
REPOSITORY
R319 Konsole
BRANCH
TerminalDisplayRemoveNonVirtualOverride
REVISION DETAIL
https://phabricator.kde.org/D17221
AFFECTED FILES
src/TerminalDisplay.cpp
src/TerminalDisplay.h
To: tcanabrava
Cc: konsole-devel, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20181128/601cef0e/attachment.html>
More information about the konsole-devel
mailing list