[konsole] [Bug 311263] "Vary the background color for each tab" option broken

[Kurt Hindenburg]

https://bugs.kde.org/show_bug.cgi?id=311263

Kurt Hindenburg <kurt.hindenburg at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |18.12
      Latest Commit|                            |https://commits.kde.org/kon
                   |                            |sole/72368b71e29a40ee27aa94
                   |                            |39432f0e764a4322ed
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Kurt Hindenburg <kurt.hindenburg at gmail.com> ---
Git commit 72368b71e29a40ee27aa9439432f0e764a4322ed by Kurt Hindenburg, on
behalf of Andrew Smith.
Committed on 22/11/2018 at 15:13.
Pushed by hindenburg into branch 'master'.

Allow small colour changes when varying dark backgrounds

Summary:
Black backgrounds don't get a (visible) random colour if "Vary the
background colour" has been checked. This is because the only
changes currently made aren't visible if the colour is black. Instead,
if we get a black background allow a small change in the colour
value so that the randomized colour is noticeable.
FIXED-IN: 18.12

Test Plan:
Create a new profile with a black background and the "Vary the
background colour" option checked. Opening new tabs with this
profile should produce tabs with slightly different background colours.

Reviewers: #konsole, konsole-devel, hindenburg

Reviewed By: #konsole, hindenburg

Subscribers: #konsole, konsole-devel

Tags: #konsole

Differential Revision: https://phabricator.kde.org/D17045

M  +9    -1    src/ColorScheme.cpp

https://commits.kde.org/konsole/72368b71e29a40ee27aa9439432f0e764a4322ed

-- 
You are receiving this mail because:
You are the assignee for the bug.