D17045: Allow small colour changes when varying dark backgrounds

Andrew Smith noreply at phabricator.kde.org
Tue Nov 20 12:42:13 GMT 2018


EspadaV8 created this revision.
Herald added a project: Konsole.
Herald added a subscriber: konsole-devel.
EspadaV8 requested review of this revision.

REVISION SUMMARY
  Black backgrounds don't get a (visible) random colour if "Vary the background
  colour" has been checked. This is because the only changes currently made aren't
  visible if the colour is black. Instead, if we get a black background allow a
  small change in the colour value so that the randomised colour is noticeable.

TEST PLAN
  Create a new profile with a black background and the "Vary the background
  colour" option checked. Opening new tabs with this profile should produce tabs
  with slightly different background colours.

REPOSITORY
  R319 Konsole

BRANCH
  311263-vary-the-background-colour-for-each-tab

REVISION DETAIL
  https://phabricator.kde.org/D17045

AFFECTED FILES
  src/ColorScheme.cpp
  src/ColorScheme.h

To: EspadaV8
Cc: konsole-devel, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20181120/2972a53f/attachment.html>


More information about the konsole-devel mailing list