D16947: fix drawing box chars, avoid storing and saving state all the time

[Martin Tobias Holmedahl Sandsmark]

sandsmark created this revision.
sandsmark added reviewers: Konsole, hindenburg.
Herald added a project: Konsole.
Herald added a subscriber: konsole-devel.
sandsmark requested review of this revision.

REVISION SUMMARY
  to get the box chars to be drawn correctly we need to turn on high quality antialiasing in qpainter. in addition only turn it on if antialiasing is enabled.
  
  lastly qpainter.save()/restore() is called very often, so try to avoid that if it isn't necessary.

TEST PLAN
  `cat tests/boxes.txt`
  
  old:
  
  F6428268: old.png <https://phabricator.kde.org/F6428268>
  
  new:
  
  F6428269: new.png <https://phabricator.kde.org/F6428269>

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D16947

AFFECTED FILES
  src/TerminalDisplay.cpp

To: sandsmark, #konsole, hindenburg
Cc: konsole-devel, #konsole, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20181117/c466d38a/attachment.html>