[konsole] [Bug 399291] Don't include trailing colons in URLs for the purpose of double-click selection

[Kurt Hindenburg]

https://bugs.kde.org/show_bug.cgi?id=399291

Kurt Hindenburg <kurt.hindenburg at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED
   Version Fixed In|                            |18.12.0
      Latest Commit|                            |https://commits.kde.org/kon
                   |                            |sole/9ce051371dcf98ad14c2df
                   |                            |fdf567fe01f0a369e5

--- Comment #5 from Kurt Hindenburg <kurt.hindenburg at gmail.com> ---
Git commit 9ce051371dcf98ad14c2dffdf567fe01f0a369e5 by Kurt Hindenburg, on
behalf of Nate Graham.
Committed on 02/11/2018 at 13:51.
Pushed by hindenburg into branch 'master'.

Don't consider a colon before whitespace to be part of a word

Summary:
Currently, colons are considered to be part of words for the purpose of
double-click selection. This allows, for example, URLs to be selected
with a double click. This is good.

However, including colons works less well for paths that end with a colon
and whitespace--such as `grep` output. Removing the colon from the list
of word characters isn't a great solutionsince then URLs can no longer be
selected by double-clicking.

This patch resolves that particular issue by always omitting a colon from
double-click selection when it's immediately followed by whitespace.
FIXED-IN: 18.12.0

Test Plan:
`grep -ri charClass .`
Then double-click on one of the paths in the output. The trailing colon
is not included in the selection.

Reviewers: #konsole, hindenburg

Reviewed By: #konsole, hindenburg

Subscribers: konsole-devel

Tags: #konsole

Differential Revision: https://phabricator.kde.org/D16578

M  +6    -2    src/TerminalDisplay.cpp

https://commits.kde.org/konsole/9ce051371dcf98ad14c2dffdf567fe01f0a369e5

-- 
You are receiving this mail because:
You are the assignee for the bug.