D16578: Don't consider a colon before whitespace to be part of a word

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Konsole, hindenburg.
Herald added a project: Konsole.
Herald added a subscriber: konsole-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Currently, colons are considered to be part of words for the purpose of double-click selection. This allows, for example, URLs to be selected with a double click. This is good.
  
  However, including colons works less well for paths that end with a colon and whitespace--such as `grep` output. Removing the colon from the list of word characters isn't a great solutionsince then URLs can no longer be selected by double-clicking.
  
  This patch resolves that particular issue by always omitting a colon from double-click selection when it's immediately followed by whitespace.
  
  BUG: 399291
  FIXED-IN: 18.12.0

TEST PLAN
  `grep -ri charClass .`
  Then double-click on one of the paths in the output. The trailing colon is not included in the selection.

REPOSITORY
  R319 Konsole

BRANCH
  trailing-colon-isnt-part-of-a-word (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D16578

AFFECTED FILES
  src/TerminalDisplay.cpp

To: ngraham, #konsole, hindenburg
Cc: konsole-devel, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20181101/64524b05/attachment.html>