D13217: Move isPrimaryScreen() to the Session

Ahmad Samir noreply at phabricator.kde.org
Thu May 31 16:37:56 UTC 2018


ahmadsamir marked an inline comment as done.
ahmadsamir added inline comments.

INLINE COMMENTS

> hindenburg wrote in TerminalDisplay.cpp:2838
> Do we need to check sessionController()->session() != nullptr?

Better safe than sorry; IIRC, there are multiple places throughout the code where the session* is checked to prevent crashes.

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D13217

To: ahmadsamir, #konsole
Cc: konsole-devel, herrold, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180531/2497d084/attachment.html>


More information about the konsole-devel mailing list