D12968: Remove triplicated code

Kurt Hindenburg noreply at phabricator.kde.org
Wed May 30 03:56:50 UTC 2018


hindenburg added a comment.


  I like the removal of duplicated code; however something still not correct.  If you have konsole debug turned on and run konsole from another term you can see "org.kde.konsole: Attempted to re-run an already running session ( 28261 )" which should not be there.  Briefly looking at the code, ViewManager::newSession has session->run() which is the removed code does not.

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D12968

To: tcanabrava, #konsole, hindenburg
Cc: konsole-devel, herrold, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180530/5864e9bf/attachment-0001.html>


More information about the konsole-devel mailing list