D13174: One Search Bar Per Tab

Tomaz Canabrava noreply at phabricator.kde.org
Mon May 28 16:15:21 UTC 2018


tcanabrava created this revision.
Restricted Application added a project: Konsole.
Restricted Application added a subscriber: konsole-devel.
tcanabrava requested review of this revision.

REVISION SUMMARY
  Remove the global search bar and allows each tab
  to have it's own search. For this I created a new
  class TerminalWidget - that's the combination of
  the TerminalDisplay and SearchBar, and extracted
  the uses of TermianlDisplay and SearchBar that
  where scattered around the code, making the resulting
  code less tangled.
  
  Testing:
  created tabs, created search boxes, searched, closed.

REPOSITORY
  R319 Konsole

BRANCH
  fixSearchTab

REVISION DETAIL
  https://phabricator.kde.org/D13174

AFFECTED FILES
  src/MainWindow.cpp
  src/Part.cpp
  src/SessionController.cpp
  src/SessionController.h
  src/TerminalDisplay.cpp
  src/TerminalDisplay.h
  src/ViewContainer.cpp
  src/ViewContainer.h
  src/ViewManager.cpp
  src/ViewManager.h

To: tcanabrava
Cc: konsole-devel, herrold, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180528/ca1aefc4/attachment.html>


More information about the konsole-devel mailing list