D13134: Invert the logic for Mouse Tracking events
Ahmad Samir
noreply at phabricator.kde.org
Mon May 28 12:51:55 UTC 2018
ahmadsamir added a comment.
In D13134#269578 <https://phabricator.kde.org/D13134#269578>, @hindenburg wrote:
> Thanks, the only issue I see is that shouldn't the two constructor initialization be swamped for true? _usesMouseTracking(false), _usesMouseTracking(false),
I think both of them should be false, because Mouse Tracking events should only be sent if the program running in the terminal indicates it's interested in such events. For example:
- Using the normal/primary screen buffer, bash isn't interested in those events
- less, which uses the secondary screen buffer, doen't have support for such events at all
- vim, should ideally want those events in mouse visual mode, but not otherwise
REPOSITORY
R319 Konsole
REVISION DETAIL
https://phabricator.kde.org/D13134
To: ahmadsamir, #konsole
Cc: hindenburg, konsole-devel, #konsole, herrold, ngraham, maximilianocuria
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180528/43d49256/attachment.html>
More information about the konsole-devel
mailing list