D13134: Use the reverse logic for Mouse Tracking events

Ahmad Samir noreply at phabricator.kde.org
Sat May 26 09:10:47 UTC 2018


ahmadsamir created this revision.
ahmadsamir added a reviewer: Konsole.
Restricted Application added a project: Konsole.
Restricted Application added a subscriber: konsole-devel.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  Previously the logic was to set "usesMouse" to false to indicate that
  the program running in the terminal supports handling mouse events
  itself, i.e. the program is interested in receiving Mouse Tracking
  events; or set to true otherwise.
  
  Since this was confusing, use the reverse logic by replacing "usesMouse"
  with "usesMouseTracking".
  
  "usesMouseTracking" is set to true when the program running in the shell
  indicates it's interested in receiving Mouse Tracking events. For
  example vim in visual mouse mode:
  http://vimdoc.sourceforge.net/htmldoc/intro.html#Normal
  
  Mouse Tracking is an XTerm extension, for more information examine:
  http://invisible-island.net/xterm/ctlseqs/ctlseqs.html#h2-Mouse-Tracking

TEST PLAN
  Before:
  
  - Execute `printf '\e[?1003h'` to enable mouse tracking mode in konsole, now when you move the mouse events will be sent to the terminal when you move, click, drag the mouse
  - Pressing and holding the Shift key should let the mouse act as normal
  - Open any file in vim, `:set mouse=a` then select some text with the mouse, note that VISUAL is displayed at the bottom of the window; right clicking _doesn't_ show the context menu as you'd expecte
  - Pressing and holding the Shift key should let the mouse act as normal
  
  Apply the diff, build, and try again, everything should work as before.

REPOSITORY
  R319 Konsole

BRANCH
  mouseTracking (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13134

AFFECTED FILES
  src/Emulation.cpp
  src/Emulation.h
  src/Profile.h
  src/Session.cpp
  src/TerminalDisplay.cpp
  src/TerminalDisplay.h
  src/Vt102Emulation.cpp

To: ahmadsamir, #konsole
Cc: konsole-devel, #konsole, herrold, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180526/98a8da6d/attachment-0001.html>


More information about the konsole-devel mailing list