[konsole] [Bug 315581] Setting terminal title with newline character print unexpected newline to the terminal.

[Kurt Hindenburg]

https://bugs.kde.org/show_bug.cgi?id=315581

Kurt Hindenburg <kurt.hindenburg at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |18.08
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/kon
                   |                            |sole/d547d1d177bd0582df95a5
                   |                            |d50dc3b37e0636748e
             Status|CONFIRMED                   |RESOLVED

--- Comment #5 from Kurt Hindenburg <kurt.hindenburg at gmail.com> ---
Git commit d547d1d177bd0582df95a5d50dc3b37e0636748e by Kurt Hindenburg, on
behalf of Ahmad Samir.
Committed on 24/05/2018 at 12:34.
Pushed by hindenburg into branch 'master'.

Ignore control characters in the text part of Xpe "ESC]" sequences

Summary:
Ignore control characters in the text part of Xpe (OSC, Operating System
Control) of the form "ESC]Pn;Pt\a" escape sequences; this matches what
XTerm docs say.

If userTitle is an empty string, set the window title to a blank space
when showWindowTitleOnTitleBar is enabled; basically if the user sets
the title to an empty string, leave it as-is.
FIXED-IN: 18.08

Test Plan:
- unset PROMPT_COMMAND, in case the shell is configured to set the
   window title via that variable
- Make sure "Show window title on the title bar" is enabled
- Execute:
$ /usr/bin/echo -e 'j\e]2;\n\aj'
- The window title is changed to the tab title text; and the output
    looks like this:
j
j

- Apply the diff, build, and try again, the window title should be
   set to an empty string (really a blank space), and the output
   should look like:
jj

Reviewers: #konsole, hindenburg

Reviewed By: #konsole, hindenburg

Subscribers: konsole-devel, #konsole

Tags: #konsole

Differential Revision: https://phabricator.kde.org/D13078

M  +6    -3    src/MainWindow.cpp
M  +6    -0    src/Vt102Emulation.cpp

https://commits.kde.org/konsole/d547d1d177bd0582df95a5d50dc3b37e0636748e

-- 
You are receiving this mail because:
You are the assignee for the bug.