D13091: Small changes on the ViewManager related to simplification of the codebase

[Tomaz Canabrava]

tcanabrava created this revision.
Restricted Application added a project: Konsole.
Restricted Application added a subscriber: konsole-devel.
tcanabrava requested review of this revision.

REVISION SUMMARY
  Code deals with the features of the container, and it's fragile,
  less dupplication is always good.
  
  Simplify Code: Use ternary instead of if
  
  Smaller code, easier to read.
  
  Code Simplifications
  
  Whitespace cleanup
  
  Remove calls that are only forward calling
  
  If those slots are actually meant to be exported,
  we can move the private ones to public as they just
  called the private ones.
  
  Remove calls from ViewManager that are unrelated
  
  Simplify Apply Profile to View
  
  Simplify setNavigationMethod

REPOSITORY
  R319 Konsole

BRANCH
  sanitizeViewManager

REVISION DETAIL
  https://phabricator.kde.org/D13091

AFFECTED FILES
  src/ViewManager.cpp
  src/ViewManager.h

To: tcanabrava
Cc: konsole-devel, herrold, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180524/226bff16/attachment.html>