[konsole] [Bug 394565] In Vt102Emulation snprintf truncation warnings while compiling

Kurt Hindenburg bugzilla_noreply at kde.org
Wed May 23 23:42:36 UTC 2018


https://bugs.kde.org/show_bug.cgi?id=394565

Kurt Hindenburg <kurt.hindenburg at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/kon
                   |                            |sole/847b72358d6c5371e7c811
                   |                            |9c7081139112ced728
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #3 from Kurt Hindenburg <kurt.hindenburg at gmail.com> ---
Git commit 847b72358d6c5371e7c8119c7081139112ced728 by Kurt Hindenburg, on
behalf of Mariusz Glebocki.
Committed on 23/05/2018 at 23:42.
Pushed by hindenburg into branch 'master'.

Silence -Wformat-truncation warnings

Summary:
Add a few bytes to a small arrays on stack in order to make compiler
happy. Those warnings are invalid in this context (as long as terminal
width and height are not larger than 8-digits-long number).

Test Plan:
* Build Konsole with GCC 8 and `-Wformat-truncation` flag

Expected result: no format-truncation warnings
Actual result: three format-truncation warnings appear

Reviewers: #konsole, hindenburg

Reviewed By: #konsole, hindenburg

Subscribers: hindenburg, konsole-devel, #konsole

Tags: #konsole

Differential Revision: https://phabricator.kde.org/D13080

M  +2    -2    src/Vt102Emulation.cpp

https://commits.kde.org/konsole/847b72358d6c5371e7c8119c7081139112ced728

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the konsole-devel mailing list