D13081: Allow any character(s) as a key in key binding.

[Mariusz Glebocki]

mglb created this revision.
mglb added a reviewer: Konsole.
Restricted Application added a project: Konsole.
Restricted Application added a subscriber: konsole-devel.
mglb requested review of this revision.

REVISION SUMMARY
  The key (the part before modifiers) is interpreted by QKeySequence.
  For special keys (everything except printable characters), it uses names
  from `Qt::Key` without `Key_` prefix. For character keys, it uses the
  character itself, and it is not possible to use e.g. `Comma`. For this
  reason limited set of characters limits possible key bindings.

TEST PLAN
  - In profile's key bindings settings (or your keysym file) create entry:
  
    key ,-Shift+Ctrl-Alt+Ansi : "Hello from keysym"
  
  Change `-Alt` to `+Alt` if you have a conflict. Do not change shift
  (the shortcut would trigger on '<' instead of ',')
  
  - Save and close settings
  - Press `Ctrl+,`
  
  Expected result: "Hello from keysym" is typed
  Actual result:
  
  - the key binding does not work
  - empty rows appear in key bindings table

REPOSITORY
  R319 Konsole

BRANCH
  wip/Allow-any-characters-as-a-key-in-key-binding (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13081

AFFECTED FILES
  src/KeyboardTranslator.cpp

To: mglb, #konsole
Cc: konsole-devel, #konsole, herrold, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180523/43add45a/attachment.html>