D12981: Improve the Keyboard tab and the KeyBindings editor

[Ahmad Samir]

ahmadsamir marked an inline comment as done.
ahmadsamir added a subscriber: hindenburg.
ahmadsamir added a comment.


  In D12981#266447 <https://phabricator.kde.org/D12981#266447>, @hindenburg wrote:
  
  > I notice you can overwrite files w/o any notice - create multiple new key bindings files and apply/ok.  You don't need to work on that just bringing it up.
  
  
  TBH, I did have code to check the name of a scheme is valid before saving (that was the main reason for reimplementing accept()), but there were multiple issues:
  
  - A scheme can have a different file name and description
  - When saving a new scheme I checked that the file name and description didn't match any existing ones, respectively
  - I added quirks to accommodate the read-only schemes in /usr/share/konsole
  
  Long story short, after I had to add more than 5-6 conditions just to achieve that (and still some stuff would make it barf), I just dropped that part of the patch. It seems to have worked as-is for so many years, probably because most users don't dabble with the keyboard translators much, and the ones that do are savvy enough not to muck it up. :)

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D12981

To: ahmadsamir, #konsole
Cc: hindenburg, konsole-devel, #konsole, herrold, ngraham, maximilianocuria
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180522/2ac31078/attachment.html>