D12981: Improve the Keyboard tab and the KeyBindings editor

[Kurt Hindenburg]

hindenburg added a comment.


  I notice you can overwrite files w/o any notice - create multiple new key bindings files and apply/ok.  You don't need to work on that just bringing it up.

INLINE COMMENTS

> KeyBindingEditor.cpp:66
>      // description edit
> +    _ui->descriptionEdit->setPlaceholderText(i18n("Description cannot be left empty."));
>      connect(_ui->descriptionEdit, &QLineEdit::textChanged, this,

I used this for the profile name entry - think it is OK here as well?

setPlaceholderText(i18nc("@label:textbox", "Enter descriptive label"));

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D12981

To: ahmadsamir, #konsole
Cc: hindenburg, konsole-devel, #konsole, herrold, ngraham, maximilianocuria
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180522/f86f5ff0/attachment.html>