D12981: Improve the Keyboard tab and the KeyBindings editor

[Ahmad Samir]

ahmadsamir added a comment.


  In D12981#266191 <https://phabricator.kde.org/D12981#266191>, @hindenburg wrote:
  
  >
  
  
  [..]
  
  > 1. You can remove the description which shouldn't be allowed - just like profile name can't be empty - I would not use a special kmessagewidget - just use something like setPlaceholderText(i18n("A name must be entered!")); and do the normal popup about missing description when Apply/OK
  
  Done, I'll update the diff shortly.
  
  > 2. The 'remove' button is for any file that the user has permissions to delete (for example on one of my system I install konsole into /usr/local)
  
  The wording in the test plan isn't clear TBH; I meant the remove button is only enabled for schemes whose parent dir is writeable for the user.

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D12981

To: ahmadsamir, #konsole
Cc: hindenburg, konsole-devel, #konsole, herrold, ngraham, maximilianocuria
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180522/50e8b73d/attachment.html>