D12733: The exported version env var should have a consistent length

[Ahmad Samir]

ahmadsamir added a comment.


  In D12733#259436 <https://phabricator.kde.org/D12733#259436>, @hindenburg wrote:
  
  >   I was wondering if .remove(".").append("0").left(6) would be easier. 
  
  
  I see, (sorry I didn't make the connection earlier).
  
  I tested that with a couple of cases, and it wouldn't work, for example:
  18.08.1  -> 1808100  -> 180810
  18.08.10 -> 18081000 -> 180810
  
  18.08.2  -> 1808200  -> 180820
  18.08.20 -> 18082000 -> 180820
  
  and if KF5 ever breaks the double-number release versions, e.g. 100.08.2, :), then that bit of code would fail. I'd rather we make the code just work for all the cases we can think of now.

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D12733

To: ahmadsamir, #konsole, hindenburg
Cc: herrold, ngraham, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180508/a577f1c9/attachment-0001.html>