D12556: Do not paint long pre-edit text outside display
Mariusz Glebocki
noreply at phabricator.kde.org
Sat May 5 23:17:23 UTC 2018
mglb updated this revision to Diff 33695.
mglb added a comment.
Every reasonable code which solves this problem gives the same assembly (with `-O2`, used in release builds), so speed will not change.
As for "more readable" you're right. Additionally I've decided to separate the original rect. Any code added in the same line as the last `QRect` parameter might "disappear" during quick code scan.
REPOSITORY
R319 Konsole
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D12556?vs=33183&id=33695
BRANCH
arc/cursor-fixes/0005-Do-not-paint-long-pre-edit-text-outside-display
REVISION DETAIL
https://phabricator.kde.org/D12556
AFFECTED FILES
src/Screen.cpp
src/TerminalDisplay.cpp
src/TerminalDisplay.h
To: mglb, #konsole
Cc: hindenburg, #konsole, herrold, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180505/f0deadcb/attachment.html>
More information about the konsole-devel
mailing list