D12655: Restore Bi-Directional text support

[Mariusz Glebocki]

mglb created this revision.
mglb added reviewers: Konsole, sassanh.
Restricted Application added a project: Konsole.
mglb requested review of this revision.

REVISION SUMMARY
  Fix regression introduced by commit a565bc9 <https://phabricator.kde.org/R319:a565bc97337a3bfc3a027f46aa2dec3e9a6f8618> (Clip character drawing
  to its own cell). When the first character in a text fragment is
  classified as RTL, rest of the fragment is also considered to be RTL
  and is passed to `drawText()` as one string. The rendering is not
  perfect (especially when RTL and LTR characters are mixed), but it
  works as before.
  
  F5830191: Screenshot_2018-05-02-07-32-16.png <https://phabricator.kde.org/F5830191>
  
  BUG: 393644

TEST PLAN
  - Display example sentences using a program which prints text directly to terminal (e.g. `echo`, `cat`):
  
    حروف به هم پیوسته
    
    کِی‌دی‌ئی (به انگلیسی: KDE) پروژه‌ای برای توسعه یک
    میزکار آزاد و متن باز است.
  
  - Display the sentences in Konsole built before commit a565bc97337a3bfc3a027f46aa2dec3e9a6f8618 <https://phabricator.kde.org/R319:a565bc97337a3bfc3a027f46aa2dec3e9a6f8618>
  - Compare visually

REPOSITORY
  R319 Konsole

BRANCH
  arc/Restore-Bi-Directional-text-support

REVISION DETAIL
  https://phabricator.kde.org/D12655

AFFECTED FILES
  src/TerminalDisplay.cpp

To: mglb, #konsole, sassanh
Cc: #konsole, herrold, ngraham, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180502/365c2bc9/attachment.html>