D11821: Fix crash when using resetColorScheme()
Ahmad Samir
noreply at phabricator.kde.org
Fri Mar 30 20:58:38 UTC 2018
ahmadsamir created this revision.
ahmadsamir added reviewers: Konsole, hindenburg.
Restricted Application added a project: Konsole.
ahmadsamir requested review of this revision.
REVISION SUMMARY
After the KNewStuff changes that were added to EditProfileDialog::removeColorScheme(),
now when resetColorScheme() calls removeColorScheme() Konsole crashes.
Change resetColorScheme() to call ColorSchemeManager::deleteColorScheme()
directly; this is more logical since there's no need to delete the row
from the color schemes list as reseting the color scheme just deletes
the relevant color scheme from the user's home dir and "re-adds" the original
one from the system-wide location.
REPOSITORY
R319 Konsole
BRANCH
fix-crach-resetColorScheme (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D11821
AFFECTED FILES
src/EditProfileDialog.cpp
To: ahmadsamir, #konsole, hindenburg
Cc: #konsole, herrold, ngraham, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180330/ca1ec7a5/attachment.html>
More information about the konsole-devel
mailing list