D11763: Properly handle wheel in read-only mode
Mariusz Glebocki
noreply at phabricator.kde.org
Wed Mar 28 02:48:20 UTC 2018
mglb created this revision.
mglb added a reviewer: Konsole.
Restricted Application added a project: Konsole.
mglb requested review of this revision.
REVISION SUMMARY
- Do not allow sending mouse events and emulated up/down keys to programs when read-only mode is enabled.
- Set the currentTerminalDisplay before sending key events, like in keyPressEvent.
- The code is restructured a bit to easily separate code allowed only when read-only mode is disabled.
TEST PLAN
- start Konsole
- run `man man` and do not press any key
- try to scroll using mouse wheel - the text should scroll
- exit
- start Konsole
- run `man man`
- turn on read only mode
- try to scroll using mouse wheel - the text should not scroll
- turn off read only mode
- try to scroll - the text should scroll normally, without jump too far
- exit
- start Konsole
- run `man man`
- press Down key
- turn on read only mode
- try to scroll using mouse wheel - the text should not scroll
- turn off read only mode
- try to scroll - the text should scroll normally, without jump too far
- exit
REPOSITORY
R319 Konsole
BRANCH
arc/properly-handle-wheel-in-read-only-mode
REVISION DETAIL
https://phabricator.kde.org/D11763
AFFECTED FILES
src/TerminalDisplay.cpp
To: mglb, #konsole
Cc: #konsole, herrold, ngraham, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180328/10d0ac85/attachment.html>
More information about the konsole-devel
mailing list