D11762: Process key event even without active TerminalDisplay

Mariusz Glebocki noreply at phabricator.kde.org
Wed Mar 28 01:10:03 UTC 2018


mglb created this revision.
Restricted Application added a subscriber: Konsole.
Restricted Application added a project: Konsole.
mglb requested review of this revision.
mglb planned changes to this revision.

REVISION SUMMARY
  There are (more or less) valid cases when currentTerminalDisplay can be
  not set:
  
  - konsole started with `--background-mode`, sendText called via D-Bus
  - text send through KPart's sendInput()
  
  It can be assumed read-only is not set in this case.
  
  This patch should also fix TerminalInterfaceTest. Currently the shell
  probably doesn't get commands send through sendInput.

TEST PLAN
  - Run `konsole --background-mode --nofork & ; sleep 2; qdbus org.kde.konsole-$! /Sessions/1 sendText $'echo test\n'`
  - Press Ctrl+Shift+F12
  - The terminal should show `echo test` command and its result

REPOSITORY
  R319 Konsole

BRANCH
  arc/process-key-event-even-without-active-terminaldisplay

REVISION DETAIL
  https://phabricator.kde.org/D11762

AFFECTED FILES
  src/Vt102Emulation.cpp

To: mglb
Cc: #konsole, herrold, ngraham, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180328/423813bd/attachment-0001.html>


More information about the konsole-devel mailing list