D11668: Allow view-controlling keys in read-only mode

Kurt Hindenburg noreply at phabricator.kde.org
Tue Mar 27 14:36:11 UTC 2018


hindenburg added a comment.


  Same test still fails on        isReadOnly = currentView->sessionController()->isReadOnly();
  
  note that is only seen when using ASAN - I'll look at it later
  
  https://build.kde.org/job/Applications%20konsole%20kf5-qt5%20FreeBSDQt5.9/166/testReport/junit/(root)/TestSuite/TerminalInterfaceTest/
  https://build.kde.org/job/Applications%20konsole%20kf5-qt5%20SUSEQt5.9/173/testReport/junit/(root)/TestSuite/TerminalInterfaceTest/
  
  I won't commit to 18.04 until this is resolved.

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D11668

To: mglb, #konsole, hindenburg
Cc: hindenburg, #konsole, herrold, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180327/a35e2be9/attachment.html>


More information about the konsole-devel mailing list