D11668: Allow view-controlling keys in read-only mode

[Mariusz Glebocki]

mglb created this revision.
Restricted Application added a subscriber: Konsole.
Restricted Application added a project: Konsole.
mglb requested review of this revision.

REVISION SUMMARY
  Allow to use scrolling (Shift+Up/Down/PgUp/PgDown/Home/End) and a key
  for showing URL hints when the view is in read-only mode.

TEST PLAN
  - Prepare
    - Turn on scrollback
    - Set at least one modifier key for "Show URL hints" (edit profile → advanced)
    - Generate a few screens of text in Konsole
    - Display some URL (e.g. `echo 'www.kde.org'`)
    - Display current time every second: `while sleep 1; do printf '\r%s' "$(date)"; done`
    - Turn on read-only mode
  - Patch tests
    - Scroll the view with Shift+Up/Down/PgUp/PgDown/Home/End - the view should scroll
    - Hold down URL hint key - the URL should be underlined with square and a digit on the left
    - Press <URL-hint-key>+1 - the URL should open in a web browser
  - Regressions tests
    - Press different keys (including Ctrl+C, Ctrl+Z, etc; skip those mapped to Konsole actions) - nothing in terminal should happen
    - Press Ctrl+S - the time should not stop updating

REPOSITORY
  R319 Konsole

BRANCH
  wip/allow-view-controlling-keys-in-read-only-mode

REVISION DETAIL
  https://phabricator.kde.org/D11668

AFFECTED FILES
  src/TerminalDisplay.cpp
  src/Vt102Emulation.cpp

To: mglb
Cc: #konsole, herrold, ngraham, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180325/9848ce94/attachment.html>