D11363: Preserve tab titles set by the user, when applying profile changes

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Konsole, hindenburg.
Restricted Application added a project: Konsole.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  When applying profile changes don't touch tab titles explicilty set by
  the user (via the rename tab dialog); the same goes when previewing
  color schemes.
  
  Update the tab text only if the user actually changed the the tab title
  fomart in the rename tab dialog.
  
  BUG: 354403

TEST PLAN
  - In a konsole window with 2 or more tabs, rename a tab using the rename-tab dialog
  - Open the Edit Profile dialog and change some settings and save, also try previewing some color schemes; note that the tab title changes are kept
  - In the Edit Profile dialog, change the tab format on the Tabs page, and apply; note that the tab title the was renamed by the user isn't changed but the tab(s) whose name wasn't changed are affected by the tab title format setting change
  
  
  
  - Open the rename-tab dialog, don't change anything and click OK; now konsole doesn't count that as a tab title change

REPOSITORY
  R319 Konsole

BRANCH
  preserve-tab-title-renames (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11363

AFFECTED FILES
  src/Session.cpp
  src/Session.h
  src/SessionController.cpp
  src/SessionController.h
  src/SessionManager.cpp

To: ahmadsamir, #konsole, hindenburg
Cc: #konsole, herrold, ngraham, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180315/39ab442b/attachment.html>