D11341: Konsole: Disable more actions when locked
Joshua Noack
noreply at phabricator.kde.org
Wed Mar 14 21:54:21 UTC 2018
jnoack created this revision.
jnoack added a reviewer: hindenburg.
Restricted Application added a subscriber: Konsole.
Restricted Application added a project: Konsole.
jnoack requested review of this revision.
REVISION SUMMARY
This patch addresses the following points:
- Ignore most DBus methods
- Disable the following actions:
clear-history, clear-history-and-reset, edit-current-profile, switch-profile
adjust-history, send-signal, zmodem-upload, edit-rename (tab bar)
- Session updates all views correctly when readonly changes
Questions:
Are there any actions missing?
Is it okay to disable all of the above?
Hide or disable?
TEST PLAN
- Actions do not show when locked
- DBus methods are ignored when locked
- Multiple views in one session get correctly updated
REPOSITORY
R319 Konsole
BRANCH
improved-readonly-mode
REVISION DETAIL
https://phabricator.kde.org/D11341
AFFECTED FILES
src/Session.cpp
src/Session.h
src/SessionController.cpp
src/SessionController.h
src/TerminalDisplay.cpp
src/TerminalDisplay.h
src/ViewContainer.cpp
To: jnoack, hindenburg
Cc: hindenburg, #konsole, herrold, ngraham
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180314/85064996/attachment.html>
More information about the konsole-devel
mailing list