D10862: Konsole: Add read-only mode

[Joshua Noack]

jnoack added a comment.


  In D10862#218315 <https://phabricator.kde.org/D10862#218315>, @hindenburg wrote:
  
  > Thanks, overall I don't see any major issues.
  >
  > There are some issues below which I don't think should hold up committing this.  Perhaps later you could work on them if you're interested.
  >
  > 1. dbus methods still work on locked tabs: example qdbus $KONSOLE_DBUS_SERVICE /Sessions/3 sendText hi
  > 2. Certain menus should be disabled on locked tabs: (right click menu) Switch Profile, * Scrollback, Rename(?). Split View..... and more...
  
  
  Yeah, I can take a look at them next weekend I think.
  
  I will update the diff regarding your comments. Should be good to go then.

INLINE COMMENTS

> hindenburg wrote in ViewContainer.cpp:307
> Why remove this action when the menu closes?

The action is added dynamically in openTabContextMenu from the respective sessionController for the underlying tab. If the action is not removed again, the context menu will keep all the actions from all different controllers.

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D10862

To: jnoack, #konsole, hindenburg
Cc: hindenburg, ngraham, #konsole
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180304/d78a1ce8/attachment.html>