D13511: Remove SearchBar from the MainWindowOverview

[Nathaniel Graham]

ngraham added a comment.


  Very nice! I found a some issues for you:
  
  - The initial "Find..." text is monospaced until I type something and hit the return key, at which point it becomes variable-width until Konsole is quit and restarted
  - If I clear the terminal display (ctrl+shift+k) while the Find panel is open, it mostly disappears, but is still technically open
  - The padding underneath the red close button is greater than the padding on its right side; it needs to be moved over to the left a few pixels
  - I feel like the overall height and width of the panel could be increased a bit. There's only only pixel separating the text field from the edge of the panel; I feel like it would look better with 2 or 4 pixels instead. Bonus points if we can round the bottom corners!

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D13511

To: tcanabrava, #konsole, hindenburg
Cc: ngraham, konsole-devel, herrold, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180614/e15a15db/attachment-0001.html>