D13511: Remove SearchBar from the MainWindowOverview:Move the SearchBar to TerminalDisplay, killing thedependency from the MainWindow and allowing it tobe positioned as an overlay.This fixes the following bugs:- Opening and closing the SearchBar...

[Tomaz Canabrava]

tcanabrava created this revision.
Restricted Application added a project: Konsole.
Restricted Application added a subscriber: konsole-devel.
tcanabrava requested review of this revision.

REVISION SUMMARY
  ...while top/htop 
  would garble the screen as top would wrongly redraw
  two rows below, filling the screen with wrong text
  
  - with tabs and splits, opening two searchbars and
  
  clicking in the close button of the first without
  focusing the terminal display first would cause
  the tabbar not to close
  
  - Smaller and prettier.
  
  This never belonged here.
  Searchbar belongs to the TerminalDisplay
  Correctly position the SearchBar on topLeft
  Fix initial size of the SearchBar
  Icons, Position and Borders
  Change the icons, positions and borders
  of the SearchBar
  Fix fill background of the Search Tab
  Don't show the menubar by default
  Fix icons & text

REPOSITORY
  R319 Konsole

BRANCH
  overlaySearchTab

REVISION DETAIL
  https://phabricator.kde.org/D13511

AFFECTED FILES
  src/IncrementalSearchBar.cpp
  src/IncrementalSearchBar.h
  src/MainWindow.cpp
  src/MainWindow.h
  src/Part.cpp
  src/SessionController.cpp
  src/SessionController.h
  src/TerminalDisplay.cpp
  src/TerminalDisplay.h

To: tcanabrava
Cc: konsole-devel, herrold, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180613/70ae8f00/attachment-0001.html>