D13174: New layout for the search bar.

[Tomaz Canabrava]

tcanabrava added a comment.


  In D13174#277568 <https://phabricator.kde.org/D13174#277568>, @ahmadsamir wrote:
  
  > I haven't tested this, but does it make sense to just make the searchBar part of the TerminalDisplay Class and do away the TerminalWidget concept? theoretically, in my mind anyway, it would make this patch a lot smaller as calls to TerminalDisplay objects wouldn't need to be changed then. (Just an untested thought, I'll hopefully try and test this tomorrow).
  
  
  You are indeed right, this patch has grown organically. First the idea was to place it in a layout in the bottom part of the TerminalDisplay, and because of that a new widget was needed, when I changed to show the overlay, it was easier to hack with the TerminalWidget as it was already there. I'm extracting the TerminalWidget and git reverting some commits.

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D13174

To: tcanabrava, #konsole, hindenburg
Cc: safaalfulaij, ahmadsamir, rizzitello, ngraham, konsole-devel, herrold, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180613/21b80cff/attachment.html>