D13174: New layout for the search bar.

[Safa Alfulaij]

safaalfulaij added inline comments.

INLINE COMMENTS

> IncrementalSearchBar.cpp:63
>      _searchEdit->installEventFilter(this);
> +    _searchEdit->setPlaceholderText(i18nc("@label:textbox", "Find:"));
>      _searchEdit->setObjectName(QStringLiteral("search-edit"));

Very small note: "Find…" :)
Semicolons are for labels, placeholder text uses three dots.

Not sure about all the string freeze thing though…

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D13174

To: tcanabrava, #konsole, hindenburg
Cc: safaalfulaij, ahmadsamir, rizzitello, ngraham, konsole-devel, herrold, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180612/e4afeb8d/attachment.html>