D13174: New layout for the search bar.

[Tomaz Canabrava]

tcanabrava added a comment.


  In D13174#276488 <https://phabricator.kde.org/D13174#276488>, @hindenburg wrote:
  
  > If the tab detached had search enabled, the search will be disabled and you need to search again
  >  ^ This could be fixed at a later point.
  >
  > If you have multiple tabs and splits ctrl + shift + f will complain about multiple shortcuts
  >  ^ This would be a blocker but I could not reproduce
  >
  > Also, from the build directory can you try running src/tests/PartManualTest and src/tests/demo_konsolepart/src/demo_konsolepart
  >
  > On my system I get a "factory" assert
  
  
  Sorry for that. I tested running the program and found no bugs so I assumed everything was right. I'll update this today / tomorrow with the assert fix plus some more testing & bugfixing.

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D13174

To: tcanabrava, #konsole, hindenburg
Cc: ahmadsamir, rizzitello, ngraham, konsole-devel, herrold, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180611/0e5a8e92/attachment-0001.html>