D13174: One Search Bar Per Tab

[Ahmad Samir]

ahmadsamir added a comment.


  One corner case comes to mind (whether it has to be fixed here or in a separate review later on), if the matched text is under the search bar, the user won't be able to see it:
  a) if there's room to scroll up/down to show the text
  b) if there's no room to scroll.
  
  The way chrome handles this is move the search bar to the right/left to show the search result, then move it back to its original location if the user goes to the next search result (if that result isn't under the search bar). (IMHO, this jumping around is a bit bothersome).

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D13174

To: tcanabrava, #konsole, hindenburg
Cc: ahmadsamir, rizzitello, ngraham, konsole-devel, herrold, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180607/d1387915/attachment.html>