[konsole] [Bug 331034] regression: can't block select in the Alternate buffer after apps indicate they are interested in mouse tracking events

[Kurt Hindenburg]

https://bugs.kde.org/show_bug.cgi?id=331034

Kurt Hindenburg <kurt.hindenburg at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/kon
                   |                            |sole/f9a26694865af3231d5f92
                   |                            |293701326478d8ea7b
             Status|CONFIRMED                   |RESOLVED
   Version Fixed In|                            |18.08

--- Comment #9 from Kurt Hindenburg <kurt.hindenburg at gmail.com> ---
Git commit f9a26694865af3231d5f92293701326478d8ea7b by Kurt Hindenburg, on
behalf of Ahmad Samir.
Committed on 06/06/2018 at 11:50.
Pushed by hindenburg into branch 'master'.

Fix block selection mode in a couple of cases

Summary:
Make it possible to extend the selection when selecting text in
column/block mode, by holding down Alt+Ctrl+Shift.

Commit e5b7480966f3121f4e1042648e29a74b9c29b2e9 disabled text selection
in apps running on the Alternate screen buffer, when they tell the
terminal they're interested in Mouse Tracking events, unless only the Shift
key is pressed; this accidentally prevented block selection mode from
working in that case. Tweak the condition, to also allow block selection
mode to work when Shift is pressed. Note that the selection can't be
extended in programs while Mouse Tracking events are enabled.
FIXED-IN: 18.08

Test Plan:
- Open a new tab and `cat` some file to have some text on the screen:
 a - Select text with no modifier keys pressed
 b - Select some text, press and hold Shift and extend the selection
 c - Press and hold Alt+Ctrl, to select text in block mode, and while
     still pressing Alt+Ctrl, press Shift and extend the selection in
     block mode

- Open some file in vim, with normal mode `:set mouse=`, and repeat a, b, c
- Switch to visual mode in vim `:set mouse=a`:
 - Hold down Shift and select text
 - Hold down Shift+Alt+Ctrl and select text in column mode
 - Note that extending the selection doesn't work in vim visual mode
   (i.e. after the app indicates it's interested in Mouse Tracking events)

Reviewers: #konsole, hindenburg

Reviewed By: #konsole, hindenburg

Subscribers: hindenburg, anthonyfieroni, konsole-devel, #konsole

Tags: #konsole

Differential Revision: https://phabricator.kde.org/D13356

M  +17   -13   src/TerminalDisplay.cpp

https://commits.kde.org/konsole/f9a26694865af3231d5f92293701326478d8ea7b

-- 
You are receiving this mail because:
You are the assignee for the bug.