D13356: Fix block selection mode in a couple of cases

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added a reviewer: Konsole.
Restricted Application added a project: Konsole.
Restricted Application added a subscriber: konsole-devel.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  Make it possible to extend the selection when selecting text in
  column/block mode, by holding down Alt+Ctrl+Shift.
  
  Commit e5b7480966f3121f4e1042648e29a74b9c29b2e9 <https://phabricator.kde.org/R319:e5b7480966f3121f4e1042648e29a74b9c29b2e9> disabled text selection
  in apps running on the Alternate screen buffer, when they tell the
  terminal they're interested in Mouse Tracking events, unless only the Shift
  key is pressed; this accidentally prevented block selection mode from
  working in that case. Tweak the condition, to also allow block selection
  mode to work when Shift is pressed. Note that the selection can't be
  extended in programs while Mouse Tracking events are enabled.
  
  BUG: 331034
  FIXED-IN: 18.08

TEST PLAN
  - Open a new tab and `cat` some file to have some text on the screen: a - Select text with no modifier keys pressed b - Select some text, press and hold Shift and extend the selection c - Press and hold Alt+Ctrl, to select text in block mode, and while still pressing Alt+Ctrl, press Shift and extend the selection in block mode
  
  - Open some file in vim, with normal mode `:set mouse=`, and repeat a, b, c
  - Switch to visual mode in vim `:set mouse=a`:
    - Hold down Shift and select text
    - Hold down Shift+Alt+Ctrl and select text in column mode
    - Note that extending the selection doesn't work in vim visual mode (i.e. after the app indicates it's interested in Mouse Tracking events)

REPOSITORY
  R319 Konsole

BRANCH
  block-selection-mode (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13356

AFFECTED FILES
  src/TerminalDisplay.cpp

To: ahmadsamir, #konsole
Cc: konsole-devel, #konsole, herrold, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180605/90c51071/attachment.html>