D13174: One Search Bar Per Tab

[Chris Rizzitello]

rizzitello added a comment.


  Identified Possible Accidental new lines. 
  Identified New things missing documents

INLINE COMMENTS

> IncrementalSearchBar.cpp:88
> +    _findNextButton->setAutoRaise(true);
> +
>      _findNextButton->setToolTip(i18nc("@info:tooltip",

extra new line

> IncrementalSearchBar.cpp:96
> +    _findPreviousButton->setAutoRaise(true);
> +
>      _findPreviousButton->setObjectName(QStringLiteral("find-previous-button"));

extra new line

> IncrementalSearchBar.cpp:107
> +    _searchFromButton->setAutoRaise(true);
> +
>      _searchFromButton->setObjectName(QStringLiteral("search-from-button"));

Extra new line

> IncrementalSearchBar.cpp:165
>      setLayout(barLayout);
> +
> +    adjustSize();

Extra new line

> IncrementalSearchBar.cpp:189
> +        _searchFromButton->setIcon(QIcon::fromTheme(QStringLiteral("go-top")));
> +
>      }

Extra new line.

> SessionController.cpp:223
>      _bookmarkValidProgramsToClear << QStringLiteral("tcsh") << QStringLiteral("zsh");
> +
> +    setupSearchBar();

New Empty line

> SessionController.cpp:523
> +        connect(_view->searchBar(), &Konsole::IncrementalSearchBar::matchRegExpToggled, this, &Konsole::SessionController::changeSearchMatch);
>  
>  }

New Empty line

> SessionController.cpp:1273
>      }
> +
>  }

New Empty line

> TerminalDisplay.h:57
> +class IncrementalSearchBar;
> +
>  /**

New Empty line

> TerminalDisplay.h:80
>      void setColorTable(const ColorEntry table[]);
> +
> +    QScrollBar *scrollBar() const;

Missing Documentation for new function.

> TerminalDisplay.h:1085
>  };
> +
> +class TerminalWidget : public QWidget {

Document

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D13174

To: tcanabrava, #konsole, hindenburg
Cc: rizzitello, ngraham, konsole-devel, herrold, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180601/3dd56241/attachment-0001.html>