D13882: Use QTabBar: drop tons of code
Kurt Hindenburg
noreply at phabricator.kde.org
Tue Jul 24 04:45:00 BST 2018
hindenburg added a comment.
In D13882#296599 <https://phabricator.kde.org/D13882#296599>, @hindenburg wrote:
> just realized this has been failing https://build.kde.org/job/Applications%20konsole%20kf5-qt5%20SUSEQt5.9/
>
> Also note, Konsole currently only requires 5.6 - I'd really perfer to not change this unless really needed.
>
> 02:50:58 /home/jenkins/workspace/Applications konsole kf5-qt5 SUSEQt5.9/src/ViewContainer.cpp:316:52: error: ‘currentType’ is not a member of ‘QOperatingSystemVersion’
> 02:50:58 const auto isDarwin = QOperatingSystemVersion::currentType() == QOperatingSystemVersion::MacOS;
I fixed this by reverting back to using ENABLE_DETACHING
REPOSITORY
R319 Konsole
REVISION DETAIL
https://phabricator.kde.org/D13882
To: tcanabrava, hindenburg, #konsole, ngraham
Cc: sandsmark, ngraham, konsole-devel, herrold, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180724/c54af9cd/attachment.html>
More information about the konsole-devel
mailing list