D14294: Re-Enable --hide-tabbar and --show-tabbar

[Kurt Hindenburg]

hindenburg added a comment.


  This seems over complex - This can wait if you want to rework when you have time.

INLINE COMMENTS

> Application.cpp:426
> +        if (m_parser->isSet(QStringLiteral("show-tabbar"))) {
> +            qDebug() << "Triggered show tabbar";
> +            window->viewManager()->setNavigationVisibility(ViewManager::AlwaysShowNavigation);

remove debug

> Application.cpp:430
> +        else if (m_parser->isSet(QStringLiteral("hide-tabbar"))) {
> +            qDebug() << "Triggered hide tabbar";
> +            window->viewManager()->setNavigationVisibility(ViewManager::AlwaysHideNavigation);

remove debug

> ViewContainer.cpp:148
>  {
> -    setTabBarAutoHide((bool) KonsoleSettings::tabBarVisibility());
> +    // if we start with --show-tabs or --hide-tabs we ignore the preferences.
> +    if (_navigationVisibility == ViewManager::NavigationNotSet) {

s/tabs/tabbar/g

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D14294

To: tcanabrava, #konsole, sandsmark, hindenburg
Cc: ngraham, konsole-devel, herrold, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180724/b9318be9/attachment-0001.html>