D13882: Use QTabBar: drop tons of code

Nathaniel Graham noreply at phabricator.kde.org
Tue Jul 17 15:39:39 BST 2018


ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Fantastic, that's fixed it! This is a terrific patch, IMHO. Let's land it in master rather than the just-created 18.08 branch, and let's also probably wait for @hindenburg's opinion, too. :) I don't feel comfortable doing a real code review for this kind of diff, so my review is for behavior only.

REPOSITORY
  R319 Konsole

BRANCH
  useQTabWidget

REVISION DETAIL
  https://phabricator.kde.org/D13882

To: tcanabrava, hindenburg, #konsole, ngraham
Cc: ngraham, konsole-devel, herrold, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180717/7aac4f35/attachment-0001.html>


More information about the konsole-devel mailing list