D13882: Use QTabBar: drop tons of code

[Nathaniel Graham]

ngraham added a comment.


  Awesome!
  
  Here are the behavioral quirks that I found during testing:
  
  - When drag-re-ordering tabs, the dragged tab visually stays on the bar now and only moves horizontally (yay!) but if you release the mouse outside of the tab bar, the dragged tab now detaches with no warning*
  - Tab context menu lost its Close menu item
  - When "Show new tab and close tab buttons" becomes checked after being unchecked, the space reserved for the New Tab button doesn't actually have that button in it until you quit and restart Konsole
  
  
  
  - It would also be nice if there was some sort of visual feedback for detaching a tab, and also a 30 or so pixel "dead zone" above and below the bar where releasing the mouse wouldn't detach the tab yet--but this is probably material for another patch. :)

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D13882

To: tcanabrava, hindenburg, #konsole
Cc: ngraham, konsole-devel, herrold, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180717/6641583a/attachment-0001.html>