D14037: IncrementalSearchBox: do not propagate unhandled keys to parent

[Mariusz Glebocki]

mglb created this revision.
Restricted Application added a project: Konsole.
Restricted Application added a subscriber: konsole-devel.
mglb requested review of this revision.

REVISION SUMMARY
  When the focus is in `IncrementalSearchBar`, unhandled keys (i.e. those
  not handled by text input box or `unhandledMovementKeyPressed` signal)
  are sent to a program running in the terminal, which is probably not
  what an user expects. At least Up, Down, and Tab keys are propagated.
  
  This patch disables propagation. Shortcuts, movement keys, and keys
  handled by search bar still works.

TEST PLAN
  - Run `cat`
  - Open search box
  - Press Up/Down/Tab key
  
  Actual result: keys are sent to `cat`
  Expected result: nothing should happen (implemented)
  Alternative expected result: focus should move from text input to first
  button
  
  Regression test:
  
  Following keys/shortcuts should work:
  
  - Shift+Up/Down/PgUp/PgDown - terminal contents scrolling
  - Ctrl+Shift+T - open new tab (unless it was changed)
  - Enter - search next
  - Esc - close search box

REPOSITORY
  R319 Konsole

BRANCH
  arc/IncrementalSearchBox-do-not-propagate-unhandled-keys-to-parent (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14037

AFFECTED FILES
  src/IncrementalSearchBar.cpp

To: mglb
Cc: konsole-devel, herrold, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180711/4a7b4190/attachment.html>