D13854: Return the default ColorScheme in case of a failure

[Tomaz Canabrava]

tcanabrava created this revision.
Restricted Application added a project: Konsole.
Restricted Application added a subscriber: konsole-devel.
tcanabrava requested review of this revision.

REVISION SUMMARY
  There's no point in returning null if we have a default
  and we would check for null and query for the default
  in all cases that we used it.
  
  Export the private header ColorScheme
  
  It's going to be used from Parts and App
  
  Add ColorScheme() to the Profile
  
  The profile used to hold the ColorScheme name, but if you
  want to query for the ColorScheme you had to call ViewManager
  but there's a class ColorSchemeManager that ViewManager used to call
  
  Just make things simple:
  
  - Profile has a colorScheme that it queries from the ColorSchemeManager
  - Use profile->colorScheme() when you wanna something from the
  
  colorScheme at the profile.

REPOSITORY
  R319 Konsole

BRANCH
  simplifySessions

REVISION DETAIL
  https://phabricator.kde.org/D13854

AFFECTED FILES
  src/ColorScheme.h
  src/ColorSchemeManager.cpp
  src/ColorSchemeManager.h
  src/EditProfileDialog.cpp
  src/MainWindow.cpp
  src/Part.cpp
  src/Profile.cpp
  src/Profile.h
  src/ViewManager.cpp
  src/ViewManager.h
  src/autotests/ProfileTest.cpp

To: tcanabrava
Cc: konsole-devel, herrold, ngraham, maximilianocuria, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180702/b46f13b6/attachment.html>