D9568: Add a way to reset changes to system-wide color schemes

[Ahmad Samir]

ahmadsamir marked 4 inline comments as done.
ahmadsamir added inline comments.

INLINE COMMENTS

> hindenburg wrote in ColorSchemeManager.cpp:224
> I'm not sure I understand this -  how can the colorscheme file not exist?  and why return true when it does not exist?
> 
> can't you just return dirInfo.isWritable(); ?

Right. (I was over-engineering apparently).

> hindenburg wrote in ColorSchemeManager.cpp:240
> actually you could use return (paths.count() > 1)

OK. Done.

> hindenburg wrote in EditProfileDialog.cpp:942
> can you name this better than on?  isResetable?
> 
> I'm not sure the "Reset" is the best way to describe what we're doing.  Nothing comes to mind though.

I changed it to use isResettable.

About the name, "Reset", it's either that or DiscardColorschemeChanges, which sort of means the same thing...

REPOSITORY
  R319 Konsole

REVISION DETAIL
  https://phabricator.kde.org/D9568

To: ahmadsamir, hindenburg, #konsole
Cc: #konsole, ngraham, hindenburg
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20180123/f91528eb/attachment.html>